Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(kratos): saml federation #54

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(kratos): saml federation #54

wants to merge 1 commit into from
+178 −3

Conversation

sebferrer
Copy link

This is related to our SAML federation PR in Kratos : ory/kratos#2653

Related Issue or Design Document

ory/kratos#1928

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got green light (please contact security@ory.sh) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation within the code base (if appropriate).

@sebferrer sebferrer changed the title feat(saml): saml 2.0 implementation feat: saml federation Nov 17, 2022
@CLAassistant
Copy link

CLAassistant commented Nov 17, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@sebferrer sebferrer changed the title feat: saml federation feat(kratos): saml federation Nov 17, 2022
@sebferrer @ThibHrrd
feat(kratos): saml 2.0 implementation
16cf630 
Signed-off-by: sebferrer <sebferrer@users.noreply.github.com>

Co-authored-by: ThibaultHerard <thibaultherard10@gmail.com>
Benehiko
Benehiko reviewed Dec 13, 2022
View reviewed changes
Copy link
Contributor

@Benehiko Benehiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good :)

Please rebase on the latest changes on master. We have updated the SDK version to v1.1.0 now and also have a make command to pull in the SDK from Kratos locally for testing.
https://github.com/ory/elements#using-local-ory-sdks

We can merge this once this PR has been merged:
ory/kratos#2653

@sebferrer
Copy link
Author

Thank you @Benehiko!
Okay I'll do that soon :)

@sebferrer sebferrer mentioned this pull request Jan 6, 2023
Open
13 tasks
@mszekiel mszekiel removed their request for review March 7, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Benehiko Benehiko Benehiko left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sebferrer @CLAassistant @Benehiko